Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI Assistant: Limit popover height and fix anchorless popover #39109

Merged
merged 4 commits into from
Aug 28, 2024
Merged

AI Assistant: Limit popover height and fix anchorless popover #39109

merged 4 commits into from
Aug 28, 2024

Conversation

dhasilva
Copy link
Contributor

Fixes #39104
Fixes #39108

Proposed changes:

  • Checks for popover parentElement on display condition
  • Limits the popover height with scrolling on the suggestions section
  • Normalized the popover header height so it stays the same no matter the state

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the editor and add a word with many suggestions, like "GN"
  • Check that the spelling suggestions are vertically limited, with a scrollbar
  • While a word with a suggestion, like "lik", fix it.
  • Check that the popover is closed correctly

@dhasilva dhasilva requested a review from a team August 27, 2024 23:33
@dhasilva dhasilva self-assigned this Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-breve-anchorless-popover branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-ai-breve-anchorless-popover

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

renatoagds
renatoagds approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@renatoagds renatoagds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renatoagds renatoagds enabled auto-merge (squash) August 28, 2024 19:54
@renatoagds renatoagds merged commit b5c169c into trunk Aug 28, 2024
55 checks passed
@renatoagds renatoagds deleted the update/jetpack-ai-breve-anchorless-popover branch August 28, 2024 20:01
@github-actions github-actions bot added this to the jetpack/13.8 milestone Aug 28, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
@dhasilva @renatoagds @gogdzl
AI Assistant: Limit popover height and fix anchorless popover (#39109)
36d78f8 
* fix anchorless popover

* limit suggestions height

* changelog

* Brief: Change overflow for suggestions container

---------

Co-authored-by: Renato Augusto Gama dos Santos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatoagds renatoagds renatoagds approved these changes

Assignees

@dhasilva dhasilva

Labels
[Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Milestone
jetpack/13.8
2 participants
@dhasilva @renatoagds